Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique constraint for unicef_id in program #4529

Merged
merged 18 commits into from
Dec 19, 2024

Conversation

pkujawa
Copy link
Contributor

@pkujawa pkujawa commented Dec 19, 2024

No description provided.

@pkujawa pkujawa self-assigned this Dec 19, 2024
@pavlo-mk
Copy link
Contributor

@johniak do we still have to add new migration into excluded_migrations migrations_script/main.py?

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (2430469) to head (3b5db8c).
Report is 19 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4529   +/-   ##
=======================================
  Coverage   84.67%   84.67%           
=======================================
  Files         508      509    +1     
  Lines       36232    36242   +10     
=======================================
+ Hits        30678    30687    +9     
- Misses       5554     5555    +1     
Flag Coverage Δ
e2e 62.61% <60.00%> (+<0.01%) ⬆️
unittests 82.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johniak
Copy link
Contributor

johniak commented Dec 19, 2024

@johniak do we still have to add new migration into excluded_migrations migrations_script/main.py?

no

@johniak johniak merged commit f3ef838 into master Dec 19, 2024
13 checks passed
@johniak johniak deleted the unique_program_unicef_id_in_program branch December 19, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants